Better Character Suggestions! #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
firedfromlife
commented
Jun 19, 2024
•
firedfromlife
commented
- Character Events now suggest characters already in the timeline first.
- Text Events now suggest characters already in the timeline first.
- Text Events now place the character from the most recent (relative to the text event) character event in the timeline first.
- Feature TimelineEditors: Better Character suggestions #1892
- Character Events now suggest characters already in the timeline first. - Text Events now suggest characters already in the timeline first. - Text Events now place the most character from the most recent (relative to the text event) character event in the timeline first.
- character was shadowing from the outer scope, updated to event_character - More descriptive and less likely to shadow
- make character.get_character_name() return Unique Identifier if possible - add check to avoid error when a character event doesn't have a character set
- Now acknowleges character and text events. - Live updates! - Ignores null values in characters and text events. - Only searches up the timeline relevant to the current event.
…edfromlife/dialogic into better-character-suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.