Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically typed subsystems #2035

Merged
merged 9 commits into from
Jan 23, 2024
Merged

Statically typed subsystems #2035

merged 9 commits into from
Jan 23, 2024

Conversation

Jowan-Spooner
Copy link
Member

This alternative to #1919 has a couple of main differences:

  • the list of subsystems is generated by a method in DialogicUtil and can thus be updated if new subsystems are added by the user
  • the subsystems keep using PascalCase. For this to work without conflic some subsystem names have been slightly altered:
    • Animation -> Animations
    • Input -> Inputs
    • Expression -> Expressions
  • The _get and _set methods have been removed. I hope this improves the auto-completion for the Dialogic class and should not be necessary anymore

@Jowan-Spooner Jowan-Spooner requested a review from CakeVR January 20, 2024 17:56
@Jowan-Spooner Jowan-Spooner merged commit fc7bddc into dialogic-godot:main Jan 23, 2024
2 checks passed
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
@Jowan-Spooner @Invertex
Statically typed subsystems (dialogic-godot#2035)
2a1337d 
- Makes subsystems actual properties on the DialogicGameHandler.
- Renames 3 subsystems for name-conflict reasons.
- Adds a method to dynamically rewrite the subsystem list when needed.
@Jowan-Spooner Jowan-Spooner deleted the typed_subsystems branch January 30, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CakeVR CakeVR Awaiting requested review from CakeVR

Assignees
No one assigned
Labels
Critical 💩 Enhance ⚡ Improve a feature's workflow. Feature✨
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jowan-Spooner