Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detached Dialogic 2 Window clears Timeline #1996

Closed
CakeVR opened this issue Jan 7, 2024 · 1 comment
Closed

Detached Dialogic 2 Window clears Timeline #1996

CakeVR opened this issue Jan 7, 2024 · 1 comment
Labels
Bug 🐞 Something isn't working Critical 💩 Needs testing More feedback/testing would be good
Milestone
Version 2.0 (beta)

Comments

@CakeVR
Copy link
Collaborator

CakeVR commented Jan 7, 2024

The problem

Describe the bug
Timeline empties when detaching the window.
Saving will override the timeline with no content or whatever has been added while detaching!

To Reproduce
I used the released Dialogic 2 Alpha 12.

Steps to reproduce the behavior:

  1. Without detached Dialogic 2 window, open a timeline.
  2. Detach the window.
  3. Check if the timeline name is still there, contents must be empty now.

This state can be fixed by switching to any other Dialogic 2 tab and back.

Expected behavior
The content of the timeline is shown when detaching the window.

Solutions

Workaround

As mentioned, switching tabs will fix this.
@CakeVR CakeVR added Bug 🐞 Something isn't working Critical 💩 labels Jan 7, 2024
@CakeVR CakeVR added this to the Version 2.0 (beta) milestone Jan 7, 2024
@Jowan-Spooner
Copy link
Member

Do you think this could be saved by triggering a save before toggeling detachment? sounds like the easiest solution to me.

@Jowan-Spooner Jowan-Spooner added the Needs testing More feedback/testing would be good label Jan 8, 2024
Jowan-Spooner added a commit to Jowan-Spooner/dialogic that referenced this issue Feb 6, 2024
@Jowan-Spooner
Remove explicit clear to fix dialogic-godot#1996
50a2865 
I'm pretty sure this isn't necessary anyways, but might be wrong. If we get leaked instances again (there is HUNDREDS of leaked StringNames all the time anyways), I will find a different solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 Something isn't working Critical 💩 Needs testing More feedback/testing would be good
Milestone
Version 2.0 (beta)
Development

No branches or pull requests
2 participants
@Jowan-Spooner @CakeVR