Repository navigation
Conversation
…proval-free by default MAF 1.23 removes AgentSkillsProviderBuilder.UseScriptApproval and makes every skill tool require approval by default. With the denying default IToolApprovalHandler that would block load_skill outright, so WithSkills now disables the three approvals unless the caller re-enables them via UseOptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Casper Nielsen <casper@diagrid.io>
… skill tool names in tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Casper Nielsen <casper@diagrid.io>
…lt; test load/read re-enable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Casper Nielsen <casper@diagrid.io>
This was referenced Oct 5, 2026
…tors Microsoft.Agents.AI 1.23 puts ApprovalResponseBindingChatClient and ApprovalNotRequiredFunctionBypassingChatClient above the FunctionInvokingChatClient in a ChatClientAgent's pipeline. UnwrapFunctionInvoking only stripped a FunctionInvokingChatClient at the top, so it returned the full pipeline and tools ran in-process inside the LLM activity, without the agent context or tool telemetry baggage that the tool activity sets. Walk the whole delegating chain and return the client below the innermost FunctionInvokingChatClient. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Casper Nielsen <casper@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps
Microsoft.Agents.AIfrom 1.9.0 to 1.23.0, along withMicrosoft.Extensions.AI10.10.0, which 1.23 requires. It also fixes the build break that turns #85 and #86 red.What 1.23 changed:
AgentSkillsProviderBuilder.UseScriptApproval()has been removed. This is theCS1061error inexamples/SkillsDemoand in the skills tests.load_skill,read_skill_resource,run_skill_script) now require approval by default. The opt-out flags areAgentSkillsProviderOptions.Disable{LoadSkill,ReadSkillResource,RunSkillScript}Approval.Why the code change is needed: this library registers
DenyingToolApprovalHandlerby default. With 1.23's defaults, everyload_skillcall would be denied, and skills would stop working for anyone who has not registered their own handler.What this PR does:
WithSkillsoverloads keep the 1.9 behaviour: skill tools need no approval unless the caller opts in.UseOptions, for exampleUseOptions(o => o.DisableRunSkillScriptApproval = false), which replacesUseScriptApproval().AgentSkillsProviderthat a caller builds and attaches throughWithContextProviders(...)keeps MAF's own default. The README says so.Tested:
Once this merges, the other updates in Dependabot's grouped #85/#86 should rebase cleanly.
🤖 Generated with Claude Code