Skip to content

Test pr files #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhruvmanila merged 10 commits into from
Nov 2, 2020
Merged

Test pr files #15

dhruvmanila merged 10 commits into from
Nov 2, 2020

Conversation

@dhruvmanila
Copy link
Owner

@dhruvmanila dhruvmanila commented Nov 2, 2020

No description provided.

@ghost
Copy link

ghost commented Nov 2, 2020 •
edited by dhruvmanila
Loading

Pull Request Report:

Pull request author: @dhruvmanila

Hello! Thank you opening the pull request but there are some errors which I detected in the files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

Following functions require tests [doctest/unittest/pytest]:

  • countIslands.py:isSafe
  • countIslands.py:dfs
  • countIslands.py:findIslands

Following functions/parameters require descriptive names:

  • countIslands.py:isSafe:A
  • countIslands.py:isSafe:N
  • countIslands.py:isSafe:M
  • countIslands.py:dfs:A
  • countIslands.py:dfs:i
  • countIslands.py:dfs:j
  • countIslands.py:dfs:N
  • countIslands.py:dfs:M
  • countIslands.py:findIslands:A
  • countIslands.py:findIslands:N
  • countIslands.py:findIslands:M

Following functions require return type hints:

NOTE: If the function returns None then provide the type hint as def function() -> None

  • countIslands.py:isSafe
  • countIslands.py:dfs
  • countIslands.py:findIslands

Following function parameters require type hints:

  • countIslands.py:isSafe:A
  • countIslands.py:isSafe:row
  • countIslands.py:isSafe:col
  • countIslands.py:isSafe:visited
  • countIslands.py:isSafe:N
  • countIslands.py:isSafe:M
  • countIslands.py:dfs:A
  • countIslands.py:dfs:i
  • countIslands.py:dfs:j
  • countIslands.py:dfs:visited
  • countIslands.py:dfs:N
  • countIslands.py:dfs:M
  • countIslands.py:findIslands:A
  • countIslands.py:findIslands:N
  • countIslands.py:findIslands:M

Relevant links:

@ghost ghost added the tests are failing label Nov 2, 2020
@ghost ghost removed the Require: Tests label Nov 2, 2020
@ghost ghost removed the tests are failing label Nov 2, 2020
@ghost ghost removed the Require: Type hints label Nov 2, 2020
@dhruvmanila dhruvmanila merged commit e7f726d into master Nov 2, 2020
@dhruvmanila dhruvmanila deleted the test_pr_files branch November 2, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila