fix: remove name property for select field labels #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our SingleSelectField and MultiSelectField were emitting a warning in the console when hovering over their label. This is because they were passing window.name to the Field name property.
Mohammer5
approved these changes
Sep 16, 2020
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
🎉 This PR is included in version 5.5.9 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266
Our SingleSelectFields and MultiSelectFields were emitting a warning in the console when hovering over their label. This is because of a faulty
namethat was being passed to theFieldcomponent. It's not present in the props, so the globalwindow.namewas passed (""). That's also why it didn't show up in linting (since window.name exists).Our select is not a labelable component (https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Form_labelable), so I've removed the name line from the SingleSelectField and MultiSelectField.