Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transfer): add prop selected to renderOption (TECH-393) #212

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

martinkrulltott
Copy link
Contributor

Fixes #105
Fixes TECH-393

Adds a selected prop (bool) to the Transfer component's renderOption. This enables consumers to use selected in the renderOption function to provide separate styles for the source options and picked options, in addition to the already existing highlighted prop.


Story example: Custom List Options
image

@martinkrulltott martinkrulltott requested a review from a team as a code owner July 10, 2020 12:48
@martinkrulltott martinkrulltott changed the title fix: add prop selected to renderOption (TECH-393) feat(transfer): add prop selected to renderOption (TECH-393) Jul 10, 2020
Copy link
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Could you add one pre-selected option to the Custom List Options story so people see the difference right away?

@martinkrulltott
Copy link
Contributor Author

@Mohammer5, added 2 pre-selected options to the story 👍
image

@martinkrulltott martinkrulltott force-pushed the fix/transfer-selected-render-option branch from 798d6f0 to c81317c Compare July 10, 2020 13:17
@cypress
Copy link

cypress bot commented Jul 10, 2020



Test summary

482 0 0 0


Run details

Project ui
Status Passed
Commit c81317c
Started Jul 10, 2020 1:21 PM
Ended Jul 10, 2020 1:32 PM
Duration 11:04 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@martinkrulltott martinkrulltott merged commit b256833 into master Jul 10, 2020
@martinkrulltott martinkrulltott deleted the fix/transfer-selected-render-option branch July 10, 2020 13:38
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer: Support custom style for selected (right side) items
3 participants