Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar input): make input editable #1445

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

feat(calendar input): make input editable #1445

wants to merge 10 commits into from

Conversation

Mohammer5
Copy link
Contributor

@Mohammer5 Mohammer5 commented Jan 16, 2024

Implements LIBS-418


Description

Makes the <CalendarInput /> editable via keyboard.
Only valid input formats are:

  • yyyy/mm/dd
  • yyyy-mm-dd

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 16, 2024

🚀 Deployed on https://pr-1445--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify January 16, 2024 08:18 Inactive
Copy link

cypress bot commented Jan 16, 2024

Passing run #3263 ↗︎

0 585 0 0 Flakiness 0

Details:

fix(calendar input editable): pass "calendar" to "validateDateString"
Project: ui Commit: 0ad8363d3f
Status: Passed Duration: 06:38 💡
Started: Mar 4, 2024 10:57 AM Ended: Mar 4, 2024 11:04 AM

Review all test suite changes for PR #1445 ↗︎

@Mohammer5 Mohammer5 changed the title Libs 418 feat(calendar input): make input editable Jan 16, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify January 16, 2024 18:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 25, 2024 09:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants