-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transfer): add prop selected to renderOption (TECH-393) #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Could you add one pre-selected option to the Custom List Options
story so people see the difference right away?
@Mohammer5, added 2 pre-selected options to the story 👍 |
798d6f0
to
c81317c
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
🎉 This PR is included in version 5.1.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fixes #105
Fixes TECH-393
Adds a
selected
prop (bool) to theTransfer
component'srenderOption
. This enables consumers to useselected
in therenderOption
function to provide separate styles for the source options and picked options, in addition to the already existinghighlighted
prop.Story example: Custom List Options