fix: build with platform d2-app-scripts #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to: https://jira.dhis2.org/browse/LIBS-1 |
Mohammer5
requested changes
Oct 21, 2020
varl
approved these changes
Oct 26, 2020
varl
approved these changes
Oct 26, 2020
dhis2-bot
added a commit
that referenced
this pull request
Oct 27, 2020
## [2.0.1](v2.0.0...v2.0.1) (2020-10-27) ### Bug Fixes * build with platform d2-app-scripts ([#144](#144)) ([018c0ed](018c0ed))
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
Note that this now uses rollup to generate a single output file, though it should be functionally identical. We may want to stop rolling up libraries for
esbuilds at some point, but if so we should do that in the platform so that it applies to all libraries at once.