Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate TEA change logs into new table [DHIS2-18474] #19321

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Migrate TEA change logs into new table [DHIS2-18474] #19321

wants to merge 4 commits into from

Conversation

muilpp
Copy link
Contributor

@muilpp muilpp commented Nov 27, 2024 •
edited
Loading

This PR is the first one focusing on tracked entity change logs:

  • Migrates TE change logs to the new table, where both previous and current values will be present.
  • The encrypted values in the old table will not be migrated to the new one, as discussed on Slack.
  • Refactored the TrackedEntityChangeLogServiceTest to extend TrackerTest, as was already done for event change logs.
  • Similarly to event change logs, Hibernate is used to fetch and create records, and a new mapper is introduced for the view in the web layer.

@muilpp muilpp marked this pull request as ready for review November 27, 2024 19:34
@muilpp muilpp requested a review from a team as a code owner November 27, 2024 19:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarQube Cloud

ameenhere
ameenhere reviewed Nov 27, 2024
View reviewed changes
...core/src/main/resources/org/hisp/dhis/trackedentity/hibernate/TrackedEntityChangeLog.hbm.xml
update="false" property-ref="username"/>

<many-to-one name="programAttribute" class="org.hisp.dhis.program.ProgramTrackedEntityAttribute"
column="trackedentityattributeid" insert="false" update="false" access="field" property-ref="attribute" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure that "trackedentityattributeid" was indeed the intention here. Even for ProgramAttribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameenhere ameenhere ameenhere left review comments

@enricocolasante enricocolasante Awaiting requested review from enricocolasante

@teleivo teleivo Awaiting requested review from teleivo

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muilpp @ameenhere