fix: close TranslationDialog after saving a translation #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same behaviour as in the apps.
|
🚀 Deployed on https://pr-2245--dhis2-dashboard.netlify.app |
jenniferarnesen
approved these changes
Mar 15, 2023
|
🎉 This PR is included in version 99.10.17 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
janhenrikoverland
pushed a commit
that referenced
this pull request
Mar 17, 2023
This is the same behaviour as in the apps.
jenniferarnesen
pushed a commit
that referenced
this pull request
Mar 22, 2023
This is the same behaviour as in the apps.
jenniferarnesen
added a commit
that referenced
this pull request
Mar 23, 2023
This is the same behaviour as in the apps. Co-authored-by: Edoardo Sabadelli <[email protected]> Co-authored-by: Jan Henrik Øverland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same behaviour as in the apps.
The dialog closing has been recently changed so it needs to be triggered in the app.