fix: when loading a dashboard set the loaded flag after the fetch so state doesn't toggle back and forth [v37] #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1976--dhis2-dashboard.netlify.app |
janhenrikoverland
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1975
loaded was set to true before firing the fetch dashboards request. When that request failed due to the cache being hacked and deleted, then catch set loaded back to false. The result was that loaded kept toggling between true and false.
In addition, after discussion with Kai, it is not necessary to listen to recordingState to determine if loading is necessary. Note that removal of that recordingState doesn't impact any behavior.