feat: use the new SharingDialog with cascading sharing #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
force-pushed
the
feat/new-sharing-dialog
branch
from
c02ed48
to
b1e0bc5
Compare
|
🚀 Deployed on https://pr-1913--dhis2-dashboard.netlify.app |
jenniferarnesen
approved these changes
Aug 31, 2021
edoardo
force-pushed
the
feat/new-sharing-dialog
branch
from
8777b4f
to
6be1eb7
Compare
* chore(deps): deduplicate yarn.lock file * fix: disable broken test * fix: disable offline tests too * fix: yarn intall force and skip offline cypress tests * fix: disable all failing cypress tests * fix: go full scorched earth and delete failing test suites Co-authored-by: Jen Jones Arnesen <[email protected]>
|
🎉 This PR is included in version 31.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
pushed a commit
that referenced
this pull request
Sep 3, 2021
jenniferarnesen
added a commit
that referenced
this pull request
Sep 6, 2021
* fix: bump analytics and ui to latest (#1927) * feat: use the new SharingDialog with cascading sharing (#1913) * fix: reenable cypress tests for offline (#1928) * fix: readd missing offlinejs file (#1929) * fix: disable dirty check on exit (DHIS2-11701) (#1930) Removing the "dirty" check which would display the "Discard changes?" modal when "Exit without saving" was clicked after making changes to the title/description. * fix: bump cli-app-scripts to solve issues with z-index and Modals (#1931) Solves issues with ui Modals and z-index. Various Modals opened under the edit mode toolbar. Co-authored-by: Jen Jones Arnesen <[email protected]> * fix: upgrade d2-ui 7.3.3 (#1932) This upgrade fixes the broken interpretations component Co-authored-by: Martin <[email protected]> Co-authored-by: Edoardo Sabadelli <[email protected]> Co-authored-by: Jan Henrik Øverland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the new SharingDialog in
ui.See the PR in
uifor the actual implementation: dhis2/ui#24TODO
uiwhen it's released in master)Example screenshot