Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable View As menu items for maps without a thematic layer [DHIS2-10671] #1632

Merged

Conversation

jenniferarnesen
Copy link
Collaborator

If a map doesn't have a thematic layer, then no chart or table can be rendered. Therefore, disable these menu items and add a tooltip informing the user

image

Copy link
Contributor

@turban turban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jenniferarnesen jenniferarnesen merged commit c521111 into master Mar 11, 2021
@jenniferarnesen jenniferarnesen deleted the fix/disable-viewas-for-maps-without-thematic branch March 11, 2021 16:40
dhis2-bot added a commit that referenced this pull request Mar 11, 2021
## [31.14.2](v31.14.1...v31.14.2) (2021-03-11)

### Bug Fixes

* disable View As menu items for maps without a thematic layer [DHIS2-10671] ([#1632](#1632)) ([c521111](c521111))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 31.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants