fix: unmount map when switching dashboard mode or changing active typ…

…e [DHIS2-9558] (#1083)

* fix: call unmount when Plugin unmounts

* fix: unmount already called when switching vis

src/components/Item/VisualizationItem/DefaultPlugin.js

@@ -95,6 +95,17 @@ class DefaultPlugin extends Component {
         this.reloadPlugin(prevProps)
     }
 
+    componentWillUnmount() {
+        if (
+            pluginManager.pluginIsAvailable(
+                this.props.item,
+                this.props.visualization
+            )
+        ) {
+            pluginManager.unmount(this.props.item, this.getActiveType())
+        }
+    }
+
     getActiveType = () =>
         this.props.visualization.activeType || this.props.item.type
 
@@ -121,11 +132,11 @@ DefaultPlugin.contextTypes = {
 
 DefaultPlugin.propTypes = {
     classes: PropTypes.object,
-    useActiveType: PropTypes.bool,
     item: PropTypes.object,
     itemFilters: PropTypes.object,
     options: PropTypes.object,
     style: PropTypes.object,
+    useActiveType: PropTypes.bool,
     visualization: PropTypes.object,
 }
 

src/components/Item/VisualizationItem/Item.js

@@ -254,13 +254,8 @@ export class Item extends Component {
     }
 
     onSelectActiveType = type => {
-        if (type === this.getActiveType()) {
-            return
-        }
-
-        pluginManager.unmount(this.props.item, this.getActiveType())
-
-        this.props.onSelectActiveType(this.props.visualization.id, type)
+        type !== this.getActiveType() &&
+            this.props.onSelectActiveType(this.props.visualization.id, type)
     }
 
     getActiveType = () =>