Skip to content

Commit

Permalink
Loosening salience assumptions in language system test.
Browse files Browse the repository at this point in the history
  • Loading branch information
dhermes committed Sep 16, 2016
1 parent 9c21eb0 commit 0bc8de4
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions system_tests/language.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,25 +73,23 @@ def _check_analyze_entities_result(self, entities):
# Verify entity 1.
self.assertEqual(entity1.name, self.NAME1)
self.assertEqual(entity1.entity_type, EntityType.PERSON)
# NOTE: As of Sept. 8, 2016, entity1.salience == 0.81992269
self.assertTrue(0.6 < entity1.salience < 1.0)
self.assertGreater(entity1.salience, 0.0)
self.assertEqual(entity1.mentions, [entity1.name])
self.assertEqual(entity1.wikipedia_url,
'http://en.wikipedia.org/wiki/Caravaggio')
self.assertEqual(entity1.metadata, {})
# Verify entity 2.
self.assertEqual(entity2.name, self.NAME2)
self.assertEqual(entity2.entity_type, EntityType.LOCATION)
# NOTE: As of Sept. 8, 2016, entity2.salience == 0.14427181
self.assertTrue(0.0 < entity2.salience < 0.4)
self.assertGreater(entity2.salience, 0.0)
self.assertEqual(entity2.mentions, [entity2.name])
self.assertEqual(entity2.wikipedia_url,
'http://en.wikipedia.org/wiki/Italy')
self.assertEqual(entity2.metadata, {})
# Verify entity 3.
self.assertEqual(entity3.name, self.NAME3)
self.assertEqual(entity3.entity_type, EntityType.EVENT)
self.assertTrue(0 < entity3.salience < 0.1)
self.assertGreater(entity3.salience, 0.0)
self.assertEqual(entity3.mentions, [entity3.name])
wiki_url = ('http://en.wikipedia.org/wiki/'
'The_Calling_of_St_Matthew_(Caravaggio)')
Expand Down

0 comments on commit 0bc8de4

Please sign in to comment.