Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove deprecated API #84

Closed
wants to merge 0 commits into from
Closed

fix: Remove deprecated API #84

wants to merge 0 commits into from

Conversation

9renpoto
Copy link
Contributor

@9renpoto 9renpoto commented Jan 25, 2020 •
edited
Loading

Closes #83

All Submissions:

  • Have you followed the guidelines in our Contributing section?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you linted your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Add any extra details about your changes

@9renpoto 9renpoto marked this pull request as ready for review January 26, 2020 01:47
dhaspden
dhaspden reviewed Jan 27, 2020
View reviewed changes
Copy link
Owner

@dhaspden dhaspden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I will pull down and test after work but generally this looks good 👍

@9renpoto 9renpoto changed the title chore: update dependencies fix: Remove deprecated API Jan 30, 2020
9renpoto
9renpoto commented Jan 30, 2020
View reviewed changes
src/util/getStripeClient.ts Outdated Show resolved Hide resolved
@9renpoto
Copy link
Contributor Author

@dhaspden Hi, Would you like to enable Build forked pull requests if you like

refs: https://circleci.com/gh/dhaspden/nestjs-stripe/edit#advanced-settings

thank you :)

dhaspden
dhaspden requested changes Feb 1, 2020
View reviewed changes
Copy link
Owner

@dhaspden dhaspden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution. Once you make these updates I plan on posting a new release!

src/util/getStripeClient.ts Outdated
@@ -16,11 +14,5 @@ export function getStripeClient({
...options,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you default the appInfo to the same values as before in the new format? Otherwise this looks great 👍

src/util/getStripeClient.spec.ts Outdated Show resolved Hide resolved
@dhaspden dhaspden added dependencies Pull requests that update a dependency file enhancement New feature or request labels Feb 1, 2020
@dhaspden dhaspden mentioned this pull request Feb 1, 2020
Closed
@pull pull bot closed this Feb 1, 2020
@9renpoto 9renpoto mentioned this pull request Feb 1, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaspden dhaspden Awaiting requested review from dhaspden

Assignees

@9renpoto 9renpoto

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deprecation warning with new Stripe version
2 participants
@9renpoto @dhaspden