Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What (if any) extra functionality does everybody think would benefit this library? #69

Open
dhaspden opened this issue Oct 18, 2019 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@dhaspden
Copy link
Owner

dhaspden commented Oct 18, 2019

Request For Feedback

Hi anybody who is reading this! Now that a few people have started to use this library I wanted to take the chance to reach out to you all. This library fulfills what it set out to do but I'd like to extend the question anyway — is there something that this library does not currently do that would be nice to have?

I toyed with the idea of webhook listeners but not sure it's worth the time investment if nobody would actually use it.

Alternatively just thumbs up this message if you think that this library is good as-is and only needs maintenance. I'll leave this up for a little bit to see if I get any responses 😃.

Thanks for using this library, it means a lot!

@dhaspden dhaspden added the help wanted Extra attention is needed label Oct 18, 2019
@dhaspden dhaspden pinned this issue Oct 18, 2019
@vanhumbeecka
Copy link

vanhumbeecka commented Oct 29, 2019

Dunno about extending it. I use it as a simple wrapper for injecting Stripe. As long as the as-is version keeps being maintained, that's certainly good enough for me.

Maybe you could extend the startup settings a bit.
For example, expose the setAppInfo and setApiVersion directly. so that you can set it to your own settings.
(right now these ones get filled in by Your package json , which is maybe not what i want.)

@dhaspden
Copy link
Owner Author

dhaspden commented Nov 5, 2019

Thanks for the feedback! I plan on maintaining the current functionality indefinitely 😄

@iamjoeker
Copy link
Contributor

IMO, WebHook listeners would be a very welcomed addition!

@checor
Copy link

checor commented Apr 14, 2020

I also agree on webhook listeners. Seems that there isn't a very clean way to do it at the moment, so using this library for webhooks would be nice!

@gabimor
Copy link

gabimor commented Feb 22, 2021

I stated using this package but switched to @golevelup/nestjs-stripe just because of the webhook support.
BUT its an actual nightmare to get it working there (after a few hours and still no success..... :(
So if you can come up with a simpler or even a better documented solution, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants