Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax bounds #2602

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Relax bounds #2602

merged 1 commit into from
Aug 28, 2024

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Aug 28, 2024

This relaxes most bounds as indicated by cabal outdated.
I've checked and all the tests pass. This allows building the library with GHC 9.10.

The only thing I've left behind is lsp as it seems like there's some breaking changes there and there's an existing PR for that.

In order to build with GHC-9.10, you will also need the following allow-newers added to cabal.project:

allow-newer: lucid:*, lsp:*, hnix:*, lens-family-th:*, dependent-sum-template:*

@mmhat
Copy link
Collaborator

mmhat commented Aug 28, 2024

LGTM; Thank you @TeofilC !

@mmhat mmhat merged commit f4412a0 into dhall-lang:main Aug 28, 2024
9 checks passed
@TeofilC TeofilC deleted the wip/teo/relax-bounsd-1 branch September 3, 2024 15:27
@georgefst
Copy link

Could we please get a corresponding Hackage revision?

@Gabriella439
Copy link
Collaborator

Oops! Sorry about that

I believe these should all be published as matching revisions to Hackage now

@TeofilC
Copy link
Contributor Author

TeofilC commented Sep 29, 2024

Thanks!

@Gabriella439
Copy link
Collaborator

you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants