Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from memory+cryptonite to base16-bytestring+cryptohash-sha256 #2335

Merged
merged 6 commits into from
Nov 17, 2021
Merged

Migrate from memory+cryptonite to base16-bytestring+cryptohash-sha256 #2335

merged 6 commits into from
Nov 17, 2021

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Nov 17, 2021 •
edited
Loading

  • cryptohash-sha256 is used in cabal-install and currently maintained by Oleg Grenrus / phadej.
  • base{16,64}-bytestring are maintained by Emily Pillmore and used in hnix.

By removing direct dependencies on memory we also save ourselves some upgrade hassle with GHC 9.4 when base will gain a Data.ByteArray module that will name-clash with memory.

@sjakobi sjakobi marked this pull request as ready for review November 17, 2021 02:26
Gabriella439
Gabriella439 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my understanding is that the author of cryptonite and memory is not as active of a maintainer any longer

@mergify mergify bot merged commit 30f9617 into master Nov 17, 2021
@mergify mergify bot deleted the sjakobi/no-memory branch November 17, 2021 17:34
@sjakobi sjakobi mentioned this pull request Nov 17, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees
No one assigned
Labels
merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjakobi @Gabriella439