Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromDhall/ToDhall for LocalTime/ZonedTime/UTCTime #2300

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented Sep 11, 2021

Follow up to #2286.

One thing to discuss is how to handle decoding UTCTime. Right now, any input timezone is accepted, and then converted to UTC. One could also argue that only the 00:00 input timezone should be accepted, with an error thrown otherwise. I would be fine with both approaches.

@Gabriella439
Copy link
Collaborator

@amesgen: I think what you have now is fine, meaning that I think it's good for utctime to convert any timezone to UTC

@amesgen amesgen marked this pull request as ready for review September 11, 2021 14:55
@Gabriella439 Gabriella439 merged commit a52a3e7 into dhall-lang:master Sep 11, 2021
@Gabriella439
Copy link
Collaborator

Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants