Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text/replace "" triggers "Compiler bug" #2181

Closed
sjakobi opened this issue May 10, 2021 · 1 comment · Fixed by #2184
Closed

Text/replace "" triggers "Compiler bug" #2181

sjakobi opened this issue May 10, 2021 · 1 comment · Fixed by #2184

Comments

@sjakobi
Copy link
Collaborator

sjakobi commented May 10, 2021

At the current master:

$ cabal run -w ghc-8.10.4 dhall:dhall -- repl
Up to date
Welcome to the Dhall v1.38.1 REPL! Type :help for more information.
⊢ Text/replace ""

Error: Compiler bug                                                        
                                                                                
An ill-typed expression was encountered during normalization.                   
Explanation: This error message means that there is a bug in the Dhall compiler.
You didn't do anything wrong, but if you would like to see this problem fixed   
then you should report the bug at:                                              
                                                                                
https://github.com/dhall-lang/dhall-haskell/issues                              

CallStack (from HasCallStack):
  error, called at src/Dhall/Eval.hs:1201:13 in dhall-1.38.1-inplace:Dhall.Eval

This was found by the "everything well-typed should normalize" test in #2154 (comment).
@sjakobi
Copy link
Collaborator Author

sjakobi commented May 10, 2021

This looks similar to the Natural/subtract 0 bug fixed in #1208.

sjakobi added a commit that referenced this issue May 11, 2021
@sjakobi
WIP: Fix normalization of Text/replace "" (#2181)
2338fe4
sjakobi added a commit to dhall-lang/dhall-lang that referenced this issue May 11, 2021
@sjakobi
Add tests for Text/replace ""
e0afc87 
These trigger a bug the current Haskell implementation
(dhall-lang/dhall-haskell#2181).
@sjakobi sjakobi mentioned this issue May 11, 2021
Merged
Gabriella439 added a commit that referenced this issue May 11, 2021
@Gabriella439
Don't panic on Text/replace ""
820aca9 
Fixes #2181
@Gabriella439 Gabriella439 mentioned this issue May 11, 2021
Merged
Gabriella439 pushed a commit to dhall-lang/dhall-lang that referenced this issue May 12, 2021
@sjakobi
Add tests for Text/replace "" (#1172)
1e0bb48 
These trigger a bug the current Haskell implementation
(dhall-lang/dhall-haskell#2181).
@mergify mergify bot closed this as completed in #2184 May 13, 2021
mergify bot pushed a commit that referenced this issue May 13, 2021
@Gabriella439
Don't panic on Text/replace "" (#2184)
4c55791 
* Don't panic on `Text/replace ""`

Fixes #2181

* Update `dhall-lang` submodule

* Fix additional `Text/replace` test failure

… caught by one of the newly-added regression tests

* Disable failing CORS tests

… for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't panic on Text/replace "" dhall-lang/dhall-haskell
1 participant
@sjakobi