Skip to content

Browser Steps - <Select> by Option Text - #1224, #1228 #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgtlmoon merged 1 commit into from
Apr 22, 2025
Merged

Browser Steps - <Select> by Option Text - #1224, #1228 #3138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions changedetectionio/blueprint/browser_steps/browser_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
'Make all child elements visible': '1 0',
'Press Enter': '0 0',
'Select by label': '1 1',
'<select> by option text': '1 1',
'Scroll down': '0 0',
'Uncheck checkbox': '1 0',
'Wait for seconds': '0 1',
Expand Down Expand Up @@ -228,6 +229,15 @@ def click_xy_operation():
except Exception as e:
logger.error(f"Error parsing x,y coordinates: {str(e)}")

def action__select_by_option_text(self, selector, value):
if not selector or not len(selector.strip()):
return

def select_operation():
self.page.select_option(selector, label=value, timeout=self.action_timeout)

self.safe_page_operation(select_operation)

def action_scroll_down(self, selector, value):
def scroll_operation():
# Some sites this doesnt work on for some reason
Expand Down
9 changes: 8 additions & 1 deletion changedetectionio/static/js/browser-steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,14 @@ $(document).ready(function () {
$('input[type=text]', first_available).first().val(x['xpath']);
$('input[placeholder="Value"]', first_available).addClass('ok').click().focus();
found_something = true;
} else {
}
else if (x['tagName'] === 'select') {
$('select', first_available).val('<select> by option text').change();
$('input[type=text]', first_available).first().val(x['xpath']);
$('input[placeholder="Value"]', first_available).addClass('ok').click().focus();
found_something = true;
}
else {
// There's no good way (that I know) to find if this
// see https://stackoverflow.com/questions/446892/how-to-find-event-listeners-on-a-dom-node-in-javascript-or-in-debugging
// https://codepen.io/azaslavsky/pen/DEJVWv
Expand Down