Skip to content

Update other methods to use screenshot#3098

Merged
dgtlmoon merged 1 commit into
masterfrom
update-other-methods-screenshot
Apr 10, 2025
Merged

Update other methods to use screenshot#3098
dgtlmoon merged 1 commit into
masterfrom
update-other-methods-screenshot

Conversation

@dgtlmoon
Copy link
Copy Markdown
Owner

@dgtlmoon dgtlmoon commented Apr 9, 2025

No description provided.

@xconverge
Copy link
Copy Markdown
Contributor

LGTM, I think this will help your sanity moving forward if you decide to make more screenshot adjustments (libraries, file formats, options, etc)

@dgtlmoon dgtlmoon merged commit cdfb3f2 into master Apr 10, 2025
13 checks passed
@dgtlmoon
Copy link
Copy Markdown
Owner Author

dgtlmoon commented Apr 10, 2025

@xconverge i'm still seeing a memory leak with your updates , I found this

python-pillow/Pillow#7935 (comment)

more so https://pillow.readthedocs.io/en/stable/reference/block_allocator.html

@dgtlmoon
Copy link
Copy Markdown
Owner Author

@xconverge without you giving actual hard evidence like using memray, i can currently say that after all of that nothing is really fixed

note - i'm ONLY testing with 1 page who has a 200,000pixel height to be sure this code is fully triggered (and re-queue every 1 second)

image

@xconverge
Copy link
Copy Markdown
Contributor

@xconverge without you giving actual hard evidence like using memray, i can currently say that after all of that nothing is really fixed

note - i'm ONLY testing with 1 page who has a 200,000pixel height to be sure this code is fully triggered (and re-queue every 1 second)

image

You can say whatever you want. I bisected the change, found the problem area, fixed what was certainly leaking, and added a feature of allowing page size to be limited. If you want to say that nothing was fixed, go for it, but I think you are not being fair and I don't want to engage further.

This was referenced May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants