Update other methods to use screenshot#3098
Conversation
|
LGTM, I think this will help your sanity moving forward if you decide to make more screenshot adjustments (libraries, file formats, options, etc) |
|
@xconverge i'm still seeing a memory leak with your updates , I found this python-pillow/Pillow#7935 (comment) more so https://pillow.readthedocs.io/en/stable/reference/block_allocator.html |
|
@xconverge without you giving actual hard evidence like using memray, i can currently say that after all of that nothing is really fixed note - i'm ONLY testing with 1 page who has a 200,000pixel height to be sure this code is fully triggered (and re-queue every 1 second) |
You can say whatever you want. I bisected the change, found the problem area, fixed what was certainly leaking, and added a feature of allowing page size to be limited. If you want to say that nothing was fixed, go for it, but I think you are not being fair and I don't want to engage further. |


No description provided.