-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Notification Error on empty watch list #2727
Conversation
Thanks! This cant be merged without a test, so i've added a test in another branch and merged it there |
Hi, great. I was thinking of looking if the test is needed, but when I rethink, I decide that maybe it is covered. |
watch = datastore.data['watching'].get(watch_uuid) | ||
watch = datastore.data['watching'].get(watch_uuid) | ||
else: | ||
watch = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this broke a lot of stuff that was not tested for, for example, sending a test notification when in restock mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not sending when restock is available? I can take a look tomorrow if you are not in a rush.
With this PR, I fix the issue when there are no watched pages on the home screen and the user try to update and test the notification option from settings. Previously error was displayed, now the test notification work.
Notification test was passed also I test manual with empty watch and available watch.