Regenerate amd64 assembly with avo v0.6.0 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchstat results: https://gist.github.com/dnr/5e35fb9331043d29a457aae81f3a8649 |
|
Thanks! |
dnr
added a commit
to temporalio/temporal
that referenced
this pull request
Sep 24, 2024
## What changed? Pick up PR dgryski/go-farm#21 ## Why? Fixes bug that could cause crashes (potential crash sites are actually in ringpop but this version will be used). See linked PR for more details. ## How did you test it? Existing tests
alexshtin
pushed a commit
to temporalio/temporal
that referenced
this pull request
Nov 5, 2024
## What changed? Pick up PR dgryski/go-farm#21 ## Why? Fixes bug that could cause crashes (potential crash sites are actually in ringpop but this version will be used). See linked PR for more details. ## How did you test it? Existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regenerates the amd64 assembly to avoid issues with clobbering BP.
This includes avo's fix mmcloughlin/avo#174 for issue mmcloughlin/avo#156: it turns out BP actually is callee-save, and this can cause crashes when the new (Go 1.21) frame pointer stack unwinder tries to unwind a stack frame that has called one of these functions.
This passes this repo's tests. I also wrote a crash reproducer that would reliably crash, which fails to crash with this change.