-
Notifications
You must be signed in to change notification settings - Fork 378
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(CI): cleanup + run CI jobs with Github actions (#304)
This PR will add workflows to run Ristretto tests. It also does some basic cleanup and updates the code owners. Notable points: - go version is now pinned in .go-version and referenced by the workflow - test.sh is deprecated since it only was only relevant for TeamCity environments (it was a fancy wrapper on top of `go test -v ./...`) - ci-ristretto-tests and ci-ristretto-lint bring this repository to parity with the dgraph repository - main.yml was removed since we are no longer automatically closing issues - Coveralls now used for test coverage - Issue template updated - Pull Request template added
- Loading branch information
1 parent
1ff978f
commit dddaaf3
Showing
14 changed files
with
272 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# CODEOWNERS info: https://help.github.com/en/articles/about-code-owners | ||
# Owners are automatically requested for review for PRs that changes code | ||
# that they own. | ||
* @manishrjain @martinmr @jarifibrahim | ||
* @akon-dey @nosql22 @joshua-goldstein @skrdgraph |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
name: "🐞 Bug Report" | ||
description: File a bug report | ||
title: "[BUG]: <Title>" | ||
labels: ["kind/bug", "status/triage"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Thank you for reporting an issue. | ||
If you suspect this could be a bug, please follow this template. | ||
- type: textarea | ||
attributes: | ||
label: What version of Ristretto are you using? | ||
description: Copy and paste the tag or commit hash used in your application's go.mod file. | ||
placeholder: | | ||
Paste here. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: What version of Go are you using? | ||
description: Copy and paste all you see using the command 'go version'. | ||
placeholder: | | ||
Paste here. | ||
validations: | ||
required: false | ||
- type: dropdown | ||
attributes: | ||
label: Have you tried reproducing the issue with the latest release? | ||
options: | ||
- "Yes" | ||
- "No" | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: What is the hardware spec (RAM, CPU, OS)? | ||
description: Share all possible context of your machine. | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: true | ||
- type: textarea | ||
attributes: | ||
label: What steps will reproduce the bug? | ||
description: Enter details about your bug (command/config used to set up Ristretto). | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: true | ||
- type: textarea | ||
attributes: | ||
label: Expected behavior and actual result. | ||
description: Enter details about your expectations. | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Additional information | ||
description: Tell us anything else you think we should know. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: "📃 Documentation Request" | ||
description: Suggest improvements, additions, or revisions to Ristretto documentation | ||
title: "[Documentation]: <Title>" | ||
labels: ["area/documentation", "status/triage"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Thank you for reporting an issue. | ||
If you think Ristretto's documentation is lacking, please explain it here. | ||
- type: textarea | ||
attributes: | ||
label: What version of Ristretto is the target? | ||
description: Is it the latest version? | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Documentation. | ||
description: Explain which part of the documentation is lacking. | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: true | ||
- type: textarea | ||
attributes: | ||
label: Additional information. | ||
description: Tell us anything else you think we should know. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
name: "⚡ Feature Request" | ||
description: Suggest a new feature | ||
title: "[FEATURE]: <Title>" | ||
labels: ["kind/feature ", "status/triage"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
Thank you for reporting an issue. | ||
If you think we can make Ristretto better, describe your feature request here. | ||
Note: Feature requests are judged based on user experience and modeled on | ||
[Go Experience Reports](https://github.com/golang/go/wiki/ExperienceReports). | ||
These reports should focus on the problems - they should not focus on and need not propose solutions. | ||
- type: dropdown | ||
attributes: | ||
label: Have you tried Ristretto before this proposal? and did not find anything similar? | ||
options: | ||
- "Yes" | ||
- "No" | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: What you wanted to do. | ||
description: Enter details about your expectations. | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: true | ||
- type: textarea | ||
attributes: | ||
label: What you actually did. | ||
description: Enter details about your experience with Ristretto. | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Why wasn't it great, with examples. | ||
description: Enter details about your expectations. | ||
placeholder: | | ||
Type here. | ||
validations: | ||
required: false | ||
- type: textarea | ||
attributes: | ||
label: Additional information. | ||
description: Any external references to support your case. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
name: "🙋 Question" | ||
description: Question related to Ristretto | ||
title: "[QUESTION]: <Title>" | ||
labels: ["kind/question ", "status/triage"] | ||
body: | ||
- type: markdown | ||
attributes: | ||
value: | | ||
The issue tracker is primarily for code related issues, bug reports, missing documentation, or feature requests. | ||
- If you have a question, please consider asking it on https://discuss.dgraph.io | ||
- type: textarea | ||
attributes: | ||
label: Question. | ||
description: Ask your Question. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<!-- | ||
Change Github PR Title | ||
Your title must be in the following format: | ||
- `topic(Area): Feature` | ||
- `Topic` must be one of `build|ci|docs|feat|fix|perf|refactor|chore|test` | ||
Sample Titles: | ||
- `feat(Enterprise)`: Backups can now get credentials from IAM | ||
- `fix(Query)`: Skipping floats that cannot be Marshalled in JSON | ||
- `perf: [Breaking]` json encoding is now 35% faster if SIMD is present | ||
- `chore`: all chores/tests will be excluded from the CHANGELOG | ||
--> | ||
|
||
## Problem | ||
<!-- | ||
Please add a description with these things: | ||
1. Explain the problem by providing a good description. | ||
2. If it fixes any GitHub issues, say "Fixes #GitHubIssue". | ||
3. If it corresponds to a Jira issue, say "Fixes DGRAPH-###". | ||
4. If this is a breaking change, please prefix `[Breaking]` in the title. In the description, please put a note with exactly who these changes are breaking for. | ||
--> | ||
|
||
## Solution | ||
<!-- | ||
Please add a description with these things: | ||
1. Explain the solution to make it easier to review the PR. | ||
2. Make it easier for the reviewer by describing complex sections with comments. | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: ci-ristretto-lint | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- main | ||
schedule: | ||
- cron: "0 * * * *" | ||
jobs: | ||
go-lint: | ||
name: lint | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: golang-lint | ||
env: | ||
# prevent OOM | ||
GOGC: 10 | ||
uses: golangci/golangci-lint-action@v2 | ||
with: | ||
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. | ||
version: v1.36 | ||
only-new-issues: true | ||
args: --timeout=10m | ||
skip-go-installation: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: ci-ristretto-tests | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- main | ||
schedule: | ||
- cron: "30 * * * *" | ||
jobs: | ||
ristretto-tests: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Get Go Version | ||
run: | | ||
#!/bin/bash | ||
DEFAULT_VERSION="1.17" | ||
GOVERSION=$({ [ -f .go-version ] && cat .go-version; } || echo $DEFAULT_VERSION) | ||
echo "GOVERSION=$GOVERSION" >> $GITHUB_ENV | ||
- name: Setup Go | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: ${{ env.GOVERSION }} | ||
- name: Run Unit Tests | ||
run: go test -race -covermode atomic -coverprofile=covprofile ./... | ||
- name: Install Goveralls | ||
run: go install github.com/mattn/goveralls@latest | ||
- name: Send Coverage Results | ||
env: | ||
COVERALLS_TOKEN: ${{ secrets.COVERALLSIO_TOKEN }} | ||
run: goveralls -coverprofile=covprofile | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
1.17.11 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
run: | ||
tests: false | ||
skip-dirs: | ||
- contrib | ||
|
||
linters-settings: | ||
lll: | ||
line-length: 120 | ||
|
||
linters: | ||
disable-all: true | ||
enable: | ||
#- errcheck | ||
#- ineffassign | ||
- gas | ||
#- gofmt | ||
#- golint | ||
#- gosimple | ||
#- govet | ||
- lll | ||
#- varcheck | ||
#- unused |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters