fix(GraphQL): This PR fix panic error when we give null value in filter connectives. #6707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JatinDev543
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
pawanrawal
approved these changes
Oct 14, 2020
Contributor
pawanrawal
left a comment
pawanrawal
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)
JatinDev543
added a commit
that referenced
this pull request
Oct 14, 2020
…er connectives. (#6707) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ```
JatinDev543
added a commit
that referenced
this pull request
Oct 14, 2020
…er connectives. (#6707) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ``` (cherry picked from commit 345b6d1)
JatinDev543
added a commit
that referenced
this pull request
Oct 14, 2020
…er connectives. (#6707) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ``` (cherry picked from commit 345b6d1)
JatinDev543
added a commit
that referenced
this pull request
Oct 15, 2020
…er connectives. (#6707) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ``` (cherry picked from commit 345b6d1)
JatinDev543
added a commit
that referenced
this pull request
Oct 15, 2020
…er connectives. (#6707) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ``` (cherry picked from commit 345b6d1)
JatinDev543
added a commit
that referenced
this pull request
Oct 15, 2020
…er connectives. (#6707) (#6736) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ``` (cherry picked from commit 345b6d1)
pawanrawal
pushed a commit
that referenced
this pull request
Nov 3, 2020
…er connectives. (#6707) (#6729) Fixes GRAPHQL-744 This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now. For example in the below filter, not connective gets skipped. ``` filter:{ id:{eq:"123"}, not:null }, ``` (cherry picked from commit 345b6d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-744
This PR fix panic error when we give null value in filter connectives. Null values corresponding to connective are skipped now.
For example in the below filter,
notconnective gets skipped.This change is
Docs Preview: