Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pb): fix generated protos #1888

Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix(pb): fix generated protos #1888

merged 1 commit into from
Feb 27, 2023

Conversation

joshua-goldstein
Copy link
Contributor

We update protobuf files and generation script to version v4.

@joshua-goldstein joshua-goldstein changed the title fix(pb): fix generates protos fix(pb): fix generated protos Feb 27, 2023
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage: 41.229% (-5.7%) from 46.929% when pulling 84859fa on joshua/pb into 31b7588 on main.

Copy link

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skrdgraph skrdgraph merged commit 0e2ebb1 into main Feb 27, 2023
@skrdgraph skrdgraph deleted the joshua/pb branch February 27, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants