-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stream): add support for incremental stream writer #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
reviewed
Jul 6, 2021
NamanJain8
changed the title
[BREAKING] feat(stream): add support for incremental stream writer
feat(stream): add support for incremental stream writer
Jul 6, 2021
ahsanbarkati
approved these changes
Jul 6, 2021
manishrjain
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @NamanJain8)
stream_writer.go, line 98 at r3 (raw file):
var once sync.Once // prepareToDrop will stop all the incomming write and flushes any pending flush tasks.
incoming
stream_writer.go, line 116 at r3 (raw file):
if level.NumTables > 0 { sw.prevLevel = level.Level }
let's handle the case where there's no data.
mangalaman93
added a commit
that referenced
this pull request
Feb 14, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental
mangalaman93
added a commit
that referenced
this pull request
Feb 14, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Feb 15, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Feb 20, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Feb 20, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Feb 22, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Feb 23, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Feb 24, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Mar 1, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Mar 1, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Mar 2, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Mar 6, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Mar 6, 2023
This PR adds support for stream writing incrementally to the DB. Adds an API: StreamWriter.PrepareIncremental This PR also has the bug fix from PR #1723.
mangalaman93
added a commit
that referenced
this pull request
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for stream writing incrementally to the DB.
Adds an API:
StreamWriter.PrepareIncremental
This change is