Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Set relative URLs in config. #1616

Merged
merged 4 commits into from
Dec 8, 2020
Merged

docs: Set relative URLs in config. #1616

merged 4 commits into from
Dec 8, 2020

Conversation

mbj36
Copy link
Contributor

@mbj36 mbj36 commented Dec 8, 2020 •
edited by manishrjain
Loading

This change is Reviewable

danielmai
danielmai approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim and @manishrjain)

@danielmai danielmai changed the title relative URLs docs: Set relative URLs in config. Dec 8, 2020
@danielmai danielmai merged commit 068c66d into master Dec 8, 2020
@danielmai danielmai deleted the staging branch December 8, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbj36 @danielmai