Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(OOM): Reuse pb.KVs in Stream #1609

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Fix(OOM): Reuse pb.KVs in Stream #1609

merged 2 commits into from
Dec 3, 2020

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Dec 3, 2020

We store a slice of pb.KVs in Iterator, so it can be used by Stream users.

This change is Reviewable

@manishrjain manishrjain merged commit 70088c6 into master Dec 3, 2020
@manishrjain manishrjain deleted the mrjn/reuse-kvs branch December 3, 2020 03:30
danielmai added a commit to hypermodeinc/dgraph that referenced this pull request Dec 3, 2020
danielmai added a commit to hypermodeinc/dgraph that referenced this pull request Dec 3, 2020
Update Badger to bring in fixes to reduce memory usage during snapshot streaming.
dgraph-io/badger@3d225d7...70088c6

- Keep the cheaper parts of the index within table struct. (dgraph-io/badger#1608)
- Fix(OOM): Reuse pb.KVs in Stream (dgraph-io/badger#1609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant