Use AllocatorPool in Stream and TableBuilder #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
pushed a commit
that referenced
this pull request
Nov 11, 2020
We removed the global z.Allocator pool from z package. Instead, we now use a new z.AllocatorPool class in the places which need a pool. In this case, we brought it to TableBuilder and Stream. Fix up a memory leak in Stream. Co-authored-by: Ibrahim Jarif <[email protected]>
danielmai
added a commit
that referenced
this pull request
Nov 11, 2020
Cherry-pick of #1593. We removed the global z.Allocator pool from z package. Instead, we now use a new z.AllocatorPool class in the places which need a pool. In this case, we brought it to TableBuilder and Stream. Fix up a memory leak in Stream. Co-authored-by: Manish R Jain <[email protected]> Co-authored-by: Ibrahim Jarif <[email protected]>
danielmai
added a commit
to hypermodeinc/dgraph
that referenced
this pull request
Nov 12, 2020
Update badger to the latest master to fix a memory leak in Badger stream (dgraph-io/badger#1593) Changes: * Update Badger to dgraph-io/badger@e002a9d * Quiet logs for tmp badger dbs in reindexing.
danielmai
added a commit
to hypermodeinc/dgraph
that referenced
this pull request
Nov 12, 2020
Update badger to the latest master to fix a memory leak in Badger stream (dgraph-io/badger#1593) Changes: * Update Badger to dgraph-io/badger@e002a9d * Quiet logs for tmp badger dbs in reindexing. Cherry-pick: * chore(btree): update ristretto to bring in improvements in b+ tree (#6875
NamanJain8
pushed a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the global z.Allocator pool from z package. Instead, we now use a new z.AllocatorPool class in the places which need a pool. In this case, we brought it to TableBuilder and Stream.
This change is