add more flags to write benchmark #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
ashish-goswami,
jarifibrahim and
manishrjain
as code owners
|
|
jarifibrahim
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Awesome work @NamanJain8 🎉
I see that following options are missing
- LoadBloomOnOpen
- Compression (add a bool to turn in on/off)
- Detect Conflicts (bool to turn it on/off)
Please add them and we're good to merge this.
|
The Travis build fails because the 32-bit builds are failing. |
jarifibrahim
pushed a commit
that referenced
this pull request
Oct 2, 2020
This PR adds flags to write test benchmark corresponding to the flags in worker/server_state.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds flags to write test benchmark corresponding to the flags in worker/server_state.go.
This change is