Add support for watching nil prefix in subscriber API #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
manishrjain
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 13, 2020
This PR adds support for watching empty prefixes (all keys) in subscribe API.
To subscribe to all changes in badger, user can run
```go
db.Subscribe(ctx, handler, nil)
```
or
```go
db.Subscribe(ctx, handler, []byte{})
```
(cherry picked from commit c6c1e5e)
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 24, 2020
This PR adds support for watching empty prefixes (all keys) in subscribe API.
To subscribe to all changes in badger, user can run
```go
db.Subscribe(ctx, handler, nil)
```
or
```go
db.Subscribe(ctx, handler, []byte{})
```
(cherry picked from commit c6c1e5e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for empty prefixes in subscribe API. This issue was discovered in https://discuss.dgraph.io/t/how-to-subscribe-to-dgraph-changes/6065/3?u=ibrahim
To subsribe to all changes in badger, user can run
or
This change is