Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one in TestPagebufferReader2 #1205

Closed
wants to merge 1 commit into from

Conversation

andhe
Copy link

@andhe andhe commented Jan 27, 2020

Fixes #1197


This change is Reviewable

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 69.78% when pulling 1bb7749 on andhe:fix-eof-test into 3e25d77 on dgraph-io:master.

@jarifibrahim
Copy link
Contributor

@andhe can you please sign the CLA?

@andhe
Copy link
Author

andhe commented Jan 29, 2020

Sorry for the trouble, but I'm not signing any CLAs.

There's absolutely no way my change is even copyrightable, so this should not be a problem for you. Even Free Software Foundation is able to take trivial patches without paperwork. (Do you really want to be that organisation with the "more anal than the FSF" slogan?). If you aren't able to handle this, please fell free to use your full creativity to reimplement "- 1". ;)

@jarifibrahim
Copy link
Contributor

Thank you @andhe for the feedback but because of the repository settings, I can't merge any PRs without the CLA signed. Thank you again for your contribution. I'll close this PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TestPageBufferReader2 test is flaky
4 participants