Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast idx to uint32 to fix compilation on i386 #1118

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Cast idx to uint32 to fix compilation on i386 #1118

merged 3 commits into from
Nov 20, 2019

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Nov 13, 2019 •
edited by manishrjain
Loading

env GOOS=linux GOARCH=386 go build no longer complains about integer overflow.

See #953 (comment)

This change is Reviewable

@jarifibrahim jarifibrahim mentioned this pull request Nov 13, 2019
Closed
@coveralls
Copy link

coveralls commented Nov 13, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 77.436% when pulling 5e8e7cf on ibrahim/fix-386-build into ffb3450 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 77.278% when pulling dce4514 on ibrahim/fix-386-build into eef7c12 on master.

ashish-goswami
ashish-goswami approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@ashish-goswami ashish-goswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @ashish-goswami and @manishrjain)

@oxzi oxzi mentioned this pull request Nov 20, 2019
Closed
manishrjain
manishrjain approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jarifibrahim jarifibrahim changed the title Cast idx to uint64 to fix compilation on i386 Cast idx to uint32 to fix compilation on i386 Nov 20, 2019
@jarifibrahim jarifibrahim merged commit fb0cdb8 into master Nov 20, 2019
@jarifibrahim jarifibrahim deleted the ibrahim/fix-386-build branch November 20, 2019 18:38
@hasyimibhar hasyimibhar mentioned this pull request Nov 22, 2019
Merged
@unknwon
Copy link

unknwon commented Nov 26, 2019

Hey, thanks for the fix! Just curious, was this patch included in the v2.0.0 tag?

@jarifibrahim
Copy link
Contributor Author

@unknwon This patch wasn't included in v2.0.0. We will release a new v2.0.1 with the bug fixes soon.

@unknwon
Copy link

unknwon commented Nov 26, 2019

Gotcha, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashish-goswami ashish-goswami ashish-goswami approved these changes

@manishrjain manishrjain manishrjain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jarifibrahim @coveralls @unknwon @manishrjain @ashish-goswami