Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce StreamDone in Stream Writer #1061

Merged
merged 15 commits into from
Oct 18, 2019
Merged

Introduce StreamDone in Stream Writer #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
55ca739
Add support for stream end in stream writer
ashish-goswami Oct 1, 2019
7d60e0f
Fix some issues
ashish-goswami Oct 1, 2019
70335b7
Linting fixes
ashish-goswami Oct 1, 2019
eaadf99
Add tests for Stream Done
ashish-goswami Oct 3, 2019
73d78bf
Move closers inside sorted writer
ashish-goswami Oct 3, 2019
e50743c
Address review comments
ashish-goswami Oct 4, 2019
f0381be
Fix AppVeyor tests
ashish-goswami Oct 4, 2019
3badcac
Address review comments
ashish-goswami Oct 10, 2019
5a1d188
Add -v in travis go test
ashish-goswami Oct 16, 2019
f065b79
Decrease no of stream to fix travis build
ashish-goswami Oct 16, 2019
6c20977
Fix maxhead while closing streams
ashish-goswami Oct 17, 2019
135834d
Add test for maxhead update in stream writer
ashish-goswami Oct 17, 2019
c1684fe
Remove test as it is failing with race
ashish-goswami Oct 17, 2019
eda20f5
Trigger license/cla
ashish-goswami Oct 18, 2019
ffb416a
Trigger license/cla2
ashish-goswami Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/cover.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ TMP=$(mktemp /tmp/badger-coverage-XXXXX.txt)
BUILD=$1
OUT=$2

set -e
set -ex

pushd $SRC &> /dev/null

# create coverage output
echo 'mode: atomic' > $OUT
for PKG in $(go list ./...|grep -v -E 'vendor'); do
go test -covermode=atomic -coverprofile=$TMP $PKG
go test -v -covermode=atomic -coverprofile=$TMP $PKG
tail -n +2 $TMP >> $OUT
done

Expand Down
135 changes: 86 additions & 49 deletions pb/pb.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pb/pb.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ message KV {

// Stream id is used to identify which stream the KV came from.
uint32 stream_id = 10;
// Stream done is used to indicate end of stream.
bool stream_done = 11;
}

message KVList {
Expand Down
Loading