[CMS PR 36585] Move fixTemplateMode to preflight and fix it in 4.0.0-2018-03-05.sql for updates from 3.10 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgrammatiko Nicholas is ok with this change here, and Brian won't answer my comment here joomla#36585 (comment) , so I think you can merge this here, and then we test your PR for the CMS. I'll try to find time later this week. |
|
Thanks so much for all the work on the update procedure. Beers on me if we ever manage to go out of this pandemic |
|
For me beer without alcohol 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
See that comment.
Don't merge that yet, let's first discuss it in the CMS PR.
Testing Instructions
Test both updating from 3.10 and from 4.0.x with having an SQL error in an update SQL script coming before "4.1.0-2021-11-28.sql".