Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations: extend source position information for properties #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmx666
Copy link

@bmx666 bmx666 commented Jan 5, 2022

merge_nodes, defined in livetree.c, uses srcpos_extend only for nodes.

bmx666 referenced this pull request in bmx666/dtc Jan 5, 2022
* add comment "/* __[|>*DELETED*<|]__ */" for
  deteled nodes, labels and properties
* comment deleted nodes, labels and properties
@dgibson dgibson self-assigned this May 25, 2022
@dgibson
Copy link
Owner

dgibson commented May 25, 2022

merge_nodes, defined in livetree.c, uses srcpos_extend only for nodes.

Sorry it's taken me forever to look at this. However, this behaviour is intentional. Because the new property value entirely overwrites the old property value, I didn't think it made sense to include the now obsolete location in the annotations.

@bmx666
Copy link
Author

bmx666 commented May 26, 2022

Sorry @dgibson but then for nodes it's look a little bit strange, because you can remove whole node and re-create same node in different dts, BUT obsolete location will be left.

@dgibson
Copy link
Owner

dgibson commented Jul 30, 2022

Sorry @dgibson but then for nodes it's look a little bit strange, because you can remove whole node and re-create same node in different dts, BUT obsolete location will be left.

That's a fair point. We should probably remove the old node srcpos information when we a /delete-node/ directive is processed.

@bmx666
Copy link
Author

bmx666 commented Jul 30, 2022

@dgibson I think after that a fair point, you understood I wanted to trace history path of property/node/label from first dts up to the latest when I asked about #62

@dgibson
Copy link
Owner

dgibson commented Jan 25, 2024

@bmx666, obviously I haven't looked at this in ages. Sorry.

If you still want to pursue this, can you make a case for the behaviour change you'd like to see, then we can go from there.

merge_nodes, defined in livetree.c, uses srcpos_extend only for nodes.

Signed-off-by: Maxim Paymushkin <[email protected]>
@bmx666
Copy link
Author

bmx666 commented Jan 26, 2024

Hi @dgibson
Sync with main branch without any conflicts.
Nothing change since my last comment -> #67 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants