-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
annotations: extend source position information for properties #67
base: main
Are you sure you want to change the base?
Conversation
* add comment "/* __[|>*DELETED*<|]__ */" for deteled nodes, labels and properties * comment deleted nodes, labels and properties
e994e39
to
c9241ba
Compare
Sorry it's taken me forever to look at this. However, this behaviour is intentional. Because the new property value entirely overwrites the old property value, I didn't think it made sense to include the now obsolete location in the annotations. |
Sorry @dgibson but then for nodes it's look a little bit strange, because you can remove whole node and re-create same node in different dts, BUT obsolete location will be left. |
That's a fair point. We should probably remove the old node srcpos information when we a |
f1aa3c6
to
2267f1b
Compare
2267f1b
to
5094a5c
Compare
fb27309
to
bcc30c8
Compare
@bmx666, obviously I haven't looked at this in ages. Sorry. If you still want to pursue this, can you make a case for the behaviour change you'd like to see, then we can go from there. |
c4067fc
to
0cc7749
Compare
merge_nodes, defined in livetree.c, uses srcpos_extend only for nodes. Signed-off-by: Maxim Paymushkin <[email protected]>
0cc7749
to
dcb3b58
Compare
Hi @dgibson |
merge_nodes, defined in livetree.c, uses srcpos_extend only for nodes.