fdtoverlay: provide better error message for missing /__symbols__
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amjad50
force-pushed
the
better_error_message_missing_symbols
branch
from
30c96b3
to
56739a2
Compare
This was added because trying to apply overlay on dtb without knowing a lot about the subject can be frustrating with strange error messages. Before this, it will tell you: `Failed to apply 'overlay.dtbo': FDT_ERR_BADOFFSET` This message is similar to what's shown in `u-boot` when trying to apply overlay Signed-off-by: Amjad Alsharafi <[email protected]>
Amjad50
force-pushed
the
better_error_message_missing_symbols
branch
from
56739a2
to
d798a3f
Compare
|
LGTM, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added because trying to apply overlay on dtb without knowing a lot about the subject can be frustrating with strange error messages.
Before this, it will tell you:
Failed to apply 'overlay.dtbo': FDT_ERR_BADOFFSETWhich doesn't explain much if you don't know.
This new message is similar to what's shown in
u-bootwhen trying to apply overlay.Reason for this is that it took me a while to debug this and understand it was an issue with
/__symbols__, and got that fromu-boot, hopefully it will make debugging life easier for future people with similar issue.