allow using labels with fdtget/fdtput #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the CLI tools fdtget and fdtput, it can be convenient to refer to a node by a label rather than having to know the full path from the root. Signed-off-by: Rasmus Villemoes <[email protected]>
We obviously need to build some dtbs with -@ to do these tests. In order to still test all the old functionality on blobs built without -@, simply run all fdtget/fdtput tests twice, with/without -@, and for the few new test cases that rely on -@, check that they fail when the blob is not built with -@. Signed-off-by: Rasmus Villemoes <[email protected]>
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be convenient and more readable to use
&labelsyntax withfdtgetandfdtput, rather than having to know the full path. This small series adds that support by hooking intofdt_path_offset_namelen()in the same place where we already allow the first component to be an alias. Of course this only works for blobs that have been built with-@, but it shouldn't affect existing use cases.[This is a re-opening of #89 which I managed to implicitly close in the process of rebasing the branch to current main.]