Allow context aware requests #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsj-ioki
force-pushed
the
with-context
branch
3 times, most recently
from
cd756b1
to
31a20d5
Compare
|
can some one at least approve workflow on this? @dghubble ? |
|
This is exactly the feature that I miss dearly in sling. It would greatly improve the dev-ex when using this lib. |
|
@michalkurzeja also look at rsj-ioki@683b46a I am trying to maintain above fork but would be happy to contribute back to this repo. Hope @dghubble allows other maintainers for this repo at some point. |
|
Plus one to this. There is no reason to not have this feature. |
Here we introduce RequestWithContext() and ReceiveWithContext() method which allow consumers to pass in a context. This is useful for working with HTTP requests where the consumer might want to control request lifetime via a context.
|
Closing as changes are now part of newly maintained hard fork https://github.com/rsjethani/rsling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we introduce RequestWithContext() and ReceiveWithContext()
method which allow consumers to pass in a context. This is useful
for working with HTTP requests where the consumer might want
to control request lifetime via a context.