Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode JSON success/failure regardless of Content-Type #26

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Decode JSON success/failure regardless of Content-Type #26

merged 1 commit into from
Oct 11, 2016

Conversation

dghubble
Copy link
Owner

@dghubble dghubble commented Oct 11, 2016 •
edited
Loading

  • Allow JSON responses to be received and decoded from APIs with unconstrained or even incorrect Content-Type headers
  • Enough folks ask about this, there is a clear preference that Sling JSON decode responses (regardless of Content-Type). Rather than writing custom response decoders to handle those edges.

rel: #14
Closes #24

@dghubble dghubble force-pushed the json-decode-any-content-type branch from ab0e55d to 072acd2 Compare October 11, 2016 06:25
@dghubble
Decode JSON success/failure regardless of Content-Type
c083b04 
* Allow JSON responses to be received and decoded from APIs
with any Content-Type
* Users prefer Sling behave this way, over writing custom
response decoders to handle edge cases
@dghubble dghubble force-pushed the json-decode-any-content-type branch from 072acd2 to c083b04 Compare October 11, 2016 16:15
@dghubble dghubble merged commit c961a43 into master Oct 11, 2016
@dghubble dghubble deleted the json-decode-any-content-type branch October 11, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dghubble