Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DibiFluent::fetch(): fixed limit clause duplication #188

Closed
wants to merge 1 commit into from
Closed

DibiFluent::fetch(): fixed limit clause duplication #188

wants to merge 1 commit into from

Conversation

castamir
Copy link
Contributor

@castamir castamir commented Oct 8, 2015

No description provided.

@castamir castamir mentioned this pull request Oct 8, 2015
Merged
@castamir
Copy link
Contributor Author

castamir commented Oct 9, 2015

I've tried many different approaches, but the result is always the same. Using _export() with limit() leads to far more clean and easy-to-read solution than using tens of other conditions for limit and offset.

I've also added test for _export() itself.

@dg dg closed this in 917478d Oct 9, 2015
dg pushed a commit that referenced this pull request Oct 9, 2015
@dg
DibiFluent::fetch(): fixed limit clause duplication [Closes #188][Closes
2d9358e 
 #186][Closes #185]
@dg
Copy link
Owner

dg commented Oct 9, 2015

Merged with bit different test, thanks.

dg pushed a commit that referenced this pull request Oct 9, 2015
@dg
DibiFluent::fetch(): fixed limit clause duplication [Closes #188][Closes
f4ae1e6 
 #186][Closes #185]
dg pushed a commit that referenced this pull request Oct 9, 2015
@dg
Fluent::fetch(): fixed limit clause duplication [Closes #188][Closes #…
20f2093 
…186][Closes #185]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@castamir @dg