%if and %lmt dosn't work together

[hrach]

$limit = 0;
$connection->query('
SELECT * FROM foo
%if ', FALSE, ' %lmt ', $limit, ' %end
');

produces

SELECT * FROM foo /* */ LIMIT 0

same with offset.

[JanTvrdik]

Why don't you just set $limit to NULL?

[hrach]

You are poiting out some irrelevant things. It's about the fact, the %lmt cluase is appended at the end without taking care of %if.

[hrach]

$limit = 0;
$connection->query('
SELECT * FROM foo
%if ', FALSE, ' LIMIT %i ', $limit, ' %end
');

works ok

[JanTvrdik]

I'm pointing out that you should not use %if with %lmt as there exists better solution.

Try to modify

dibi/dibi/libs/DibiTranslator.php

Line 538 in cbdcc3f

} elseif ($mod === 'lmt') { // apply limit

:

if ($this->args[$cursor] !== NULL && !$this->comment) $this->limit = (int) $this->args[$cursor];

[hrach]

I'm pointing out that using %if don't have to include only %lmt expression, it could include more. I've solved by %i modifier, the top limits don't borther me.

[himdel]

I've just hit the same issue, apparently affects both %ofs and %lmt:

\dibi::query([ 'SELECT * FROM foo', '%if', false, '%lmt', 3, '%ofs', 5, '%end' ]);

yields

SELECT * FROM foo /* */ LIMIT 3 OFFSET 5

Obviously settings the limit or offset to null works just fine as a workaround, but, well, what's the point of %if if not not to have to special case these things outside of SQL.

IMHO something like ...'%if', $paging_enabled, '%lmt'... is much more readable than some adhoc setting stuff to null.