First sketch of the new property interface #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
|
Compiles and unit tests of xtypes_generator, xdbi and xtypes run through. |
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
NOTE: nested properties are normally identified by a JSON pointer (e.g. /a/nested/property). Functions should not contain these characters, so they will get renamed (e.g. set|get_a_nested_property() ) Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
… default_value is null Signed-off-by: Moritz Schilling <[email protected]>
NOTE: We want to reuse this for edge properties Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
Signed-off-by: Moritz Schilling <[email protected]>
…new_property_mechanism # Conflicts: # src/XType.cpp Signed-off-by: Moritz Schilling <[email protected]>
|
@hwiedPro @Priyanka328 Could you please review these changes? I think they are now ready to be merged. |
NOTE: This will allow to use 'type' as a subkey Signed-off-by: Moritz Schilling <[email protected]>
|
@hwiedPro @Priyanka328 Ping |
Priyanka328
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2