Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the s-shaped 3d trajectory #28

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

haider8645
Copy link
Collaborator

Text from original issue in gitlab:

_

The 3-D curves returned by Planner::plan may return very tiny S-curves. This happens (as far as we remember) when the z-change between two steps is much (no idea how much) bigger than the xy-change. Those small s-curves lead to stuttering when executed by the trajectory follower (i.e. it drives forward, stops, drives backward, stops, drives forward again (to follow the S).
A fix exists but that fix just sets z=0 for all trajectory steps. This fix works because the trajectory follower (at the time of writing) ignores the z-axsis anyway.
This bug needs to be implemented and fixed :-)

_
As IS:
image

To Be:
image

Solution:

The spline points are offset by the posWorld and start then projected on the actual plane of the trav patch.

@haider8645 haider8645 added the enhancement New feature or request label Nov 25, 2024
@haider8645 haider8645 marked this pull request as draft November 25, 2024 12:27
@haider8645

This comment was marked as resolved.

@haider8645

This comment was marked as resolved.

@haider8645 haider8645 marked this pull request as ready for review November 25, 2024 14:08
@haider8645
Copy link
Collaborator Author

haider8645 commented Nov 25, 2024

On inclines the projection along the plane normal results in a small offset to the goalPose. Green points results in red points are projection. This needs to be checked next:

image

@haider8645
Copy link
Collaborator Author

Intersecting a line through the trajectory point with the trav node plane solves the position offset issue
image

@haider8645 haider8645 merged commit 690d349 into main Nov 26, 2024
2 checks passed
@haider8645 haider8645 deleted the fix/s_shaped_3d_trajectory branch November 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant