Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of max step height on sloped terrain #2

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

haider8645
Copy link
Contributor

@haider8645 haider8645 commented Nov 11, 2024

Hello @chhtz,

here the PR for the change to handling of step height check on sloped terrain.

  • We would need to add a dependency to cgal in ugv installation instructions for this change

Best,
Haider

@haider8645 haider8645 self-assigned this Nov 13, 2024
@haider8645 haider8645 added the enhancement New feature or request label Nov 13, 2024
@haider8645
Copy link
Contributor Author

@m0rsch1 after testing, please let us know if this branch solves the issue of the strange obstacles.

@m0rsch1
Copy link

m0rsch1 commented Nov 20, 2024

@haider8645 This is a BIG improvement on the map quality and needs to be merged asap 🥇
I would suggest, that you/we later perform a complete review of this library to even further improve this.

@m0rsch1
Copy link

m0rsch1 commented Nov 20, 2024

Screenshot from 2024-11-20 16-50-46
Screenshot from 2024-11-20 16-50-06

@haider8645
Copy link
Contributor Author

@chhtz has some ideas of improving the polygon intersection with the MLS. We could discuss that as the next step as one of the ways to improve the performance.

@haider8645
Copy link
Contributor Author

I am now writing some tests so that we can improve the performance and also compare the time taken for the trav map expansion scaling with map size and number of collisions

@haider8645
Copy link
Contributor Author

image

@haider8645 haider8645 mentioned this pull request Nov 21, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants